Skip to content

Introduce border color theming option for default Card #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025
Merged

Introduce border color theming option for default Card #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Card/Card.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
flex-direction: column;
min-width: 0; // 1.
color: var(--rui-local-color);
border: theme.$border-width solid var(--rui-local-border-color, transparent);
border: theme.$border-width solid var(--rui-local-border-color, theme.$border-color);
border-radius: theme.$border-radius;
background-color: var(--rui-local-background-color, theme.$background-color);
}
Expand Down
21 changes: 11 additions & 10 deletions src/components/Card/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,16 +289,17 @@ Separate your card actions with CardFooter. See

### Common Theming Options

| Custom Property | Description |
|------------------------------------------------------|--------------------------------------------------------------|
| `--rui-Card__padding` | Padding shared by card header, body and footer |
| `--rui-Card__border-width` | Border width |
| `--rui-Card__border-radius` | Corner radius |
| `--rui-Card__background-color` | Card background color |
| `--rui-Card--dense__padding` | Padding of dense card |
| `--rui-Card--raised__box-shadow` | Box shadow of raised card |
| `--rui-Card--disabled__background-color` | Card background color in disabled state |
| `--rui-Card--disabled__opacity` | Card opacity in disabled state |
| Custom Property | Description |
|------------------------------------------|------------------------------------------------|
| `--rui-Card__padding` | Padding shared by card header, body and footer |
| `--rui-Card__border-width` | Border width |
| `--rui-Card__border-color` | Border color |
| `--rui-Card__border-radius` | Corner radius |
| `--rui-Card__background-color` | Card background color |
| `--rui-Card--dense__padding` | Padding of dense card |
| `--rui-Card--raised__box-shadow` | Box shadow of raised card |
| `--rui-Card--disabled__background-color` | Card background color in disabled state |
| `--rui-Card--disabled__opacity` | Card opacity in disabled state |

### Theming Variants

Expand Down
1 change: 1 addition & 0 deletions src/components/Card/_theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
$padding: var(--rui-Card__padding);
$border-width: var(--rui-Card__border-width);
$border-color: var(--rui-Card__border-color);
$border-radius: var(--rui-Card__border-radius);
$background-color: var(--rui-Card__background-color);

Expand Down
1 change: 1 addition & 0 deletions src/theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,6 +825,7 @@

--rui-Card__padding: var(--rui-dimension-space-4);
--rui-Card__border-width: var(--rui-dimension-border-width-1);
--rui-Card__border-color: var(--rui-color-border-primary);
--rui-Card__border-radius: var(--rui-dimension-radius-2);
--rui-Card__background-color: var(--rui-color-background-layer-1);
--rui-Card--dense__padding: var(--rui-dimension-space-2);
Expand Down