Ensure loading button with asChild renders the correct element
#752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chaance
force-pushed
the
chance/fix-loading-button-with-aschild
branch
from
9720b8b to
1cb89bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
asChildwith the button component in theloadingstate is currently broken. Because we wrap the child (assuming the child represents the inner contents of the button rather than the button element itself), RadixSlotis unable to resolve the slottable component since it is not a direct child of the slottable component. The result is that the button does not render a wrapping DOM element, and the loading spinner ends up positioned relative to nearest relative container.This PR solves the problem by extracting the nested element's children, wrapping them, passing that into a clone of the element passed to the children prop.