Change type of select placeholder from string to ReactNode
#693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lucasmotta
requested changes
Jul 1, 2025
DanielleHuisman
force-pushed
the
fix/select-placeholder-type
branch
from
7d95533 to
6f12c4a
Compare
lucasmotta
approved these changes
Jul 2, 2025
|
@lucasmotta Could you merge this PR or is something blocking this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
placeholderprop ofSelectcurrently accepts only thestringtype, but the prop is passed directly toSelectPrimitive.Value(source), which accepts any React node (source).This PR changes to
placeholdertype toReactNode, which resolves the inconsistency.Testing steps
Pass a React node to
placeholderand it will produce a type error.Relates issues / PRs
None