Fix babel error issue #13643
Merged
Fix babel error issue #13643
+109
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when lang: en is passed, babel-english needs to be installed. This follows up fix on tinytex R package too about new error handling cause is new pandoc way to setup babel, and maybe new babel error in log
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
been seeing this a lot past few days |
|
yeah same problem that I am trying to fix. It means what I did is not enouhg 😞 I'll check it again |
This reverts commit 7cd8906.
|
OK so in fact, I don't know if this is recent Pandoc or Babel, but the messages have changed, and our auto installation is not working anymore... this is related to tinytex also. I'll solve this all in this PR. |
Updated regex to accept both backtick-quote (`Spanish') and straight-quote
('Spanish') formats for detecting missing hyphenation packages.
Added unit tests and modified smoke-all tests to skip package removal on CI.
This should be good now ! 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when lang: en is passed, babel-english needs to be installed.
This follows up fix on tinytex R package too about new error handling
cause is new pandoc way to setup babel, and maybe new babel error in log
fixes #13641
fixes #13633