Improve typing of models.HasIdCondition

[alonme]

All Submissions:

• Contributions should target the dev branch. Did you create your branch from dev?
• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Fixes #1035

[netlify]

✅ Deploy Preview for poetic-froyo-8baba7 ready!

Name	Link
🔨 Latest commit	458a05a
🔍 Latest deploy log	https://app.netlify.com/projects/poetic-froyo-8baba7/deploys/6867fc573decc200086be609
😎 Deploy Preview	https://deploy-preview-1036--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

📝 Walkthrough

Walkthrough

The type annotation for the has_id field in the HasIdCondition class within qdrant_client/http/models/models.py was changed from List["ExtendedPointId"] to Sequence["ExtendedPointId"]. This modification broadens the accepted types for the has_id attribute from only lists to any sequence type, improving compatibility with static type checkers. No other logic or functional code was altered.

Assessment against linked issues

Objective	Addressed	Explanation
Update has_id typing in HasIdCondition from List to Sequence (#1035)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were found.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf515ae and 458a05a.

📒 Files selected for processing (1)

• qdrant_client/http/models/models.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Redirect rules - poetic-froyo-8baba7
• GitHub Check: Header rules - poetic-froyo-8baba7
• GitHub Check: Pages changed - poetic-froyo-8baba7

🔇 Additional comments (2)

qdrant_client/http/models/models.py (2)

3-3: Import looks good

Adding Sequence keeps the typing explicit and avoids from collections.abc import Sequence divergence. No issues spotted.

---

934-934: No in-place mutations of has_id found – change is safe

I searched the entire codebase for any .append(), .extend(), or += calls on has_id and found none. Switching from List to Sequence is therefore safe—Pydantic will still coerce inputs to a list at runtime, and no existing code relies on mutating has_id in place.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[alonme]

Hey @joein - really small fix to improve typing, can you please review 😄

[generall]

Hey @alonme, the file you changed is auto-generated. It will be overwritten by release process

[alonme]

@generall Cool thanks,
Would probably add some indication of that at the top of the file.

I see that you use github.com:qdrant/pydantic_openapi_v3.git - which i assume is private?
Is that based on an opensource? what do you see as the way forward to fix this?

[alonme]

Hey @generall, How can we push this forward?

[generall]

@joein wdyt?

[joein]

It's not the first time we're facing it, it is related to covariant and invariant types.

I think it's actually a big time consuming issue and it is larger than just changing 2 files, unfortunately

Also, changing list to sequence will make type checker complain when someone will try to add item to the ids list since sequence is an immutable type

To recap: I think it is not a trivial issue and not of the highest priority at the moment. We might return to it a bit later.