-
Notifications
You must be signed in to change notification settings - Fork 45
Get conda builds in GIthub workflow mostly working #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Recipe updates based on information gleaned from slycot-feedstock.
|
closed and re-opened to get Github actions to rerun, in the hope that whatever was broken with |
|
The CI failures are in both Windows test runs, in tests unrelated to Slycot (I think). Evidently these two optimization cases are expected to not converge, but in CI they do. @murrayrm I'm not familiar with the optimization code, and in particular if this problem should never converge (in which case I guess there's a bug somewhere), or if it's that whatever optimizer is used can now handle this problem (but why should Windows optimization only have this property?). I see python-control has |
|
I've opened python-control/python-control#1182 to allow only Slycot-dependent tests to be selected in pytest. |
|
Tests pass, at last. I haven't checked the coverage decrease, but it may be because of decrease in coverage of python-control, not Slycot, since this only runs Slycot-related python-control tests. The reported decrease is relatively modest because I think I see |
|
Coverage is only for the Slycot Python files, and the reduction in coverage was because my attempt to test "only" Slycot python-control functions wasn't quite right. See python-control/python-control#1185 for an updated version. |
|
Coverage restored. Any objections to merging this? |
meta.yaml and conda_build_config.yaml copied and adapted from conda-forge/slycot-feedstock.
The failures in testing on OSX seem to be due to something with coveralls; the failures happen (at least on my repo - tests yet to run here) at coverage-collection time, and this happens for both conda and wheel tests. I didn't change the wheel build, and these OSX wheel tests passed completely in the most recent merged PR gh-294.
I tried to get rid of the various conda warnings encountered through the build, but ended up with a free-threaded python (!) when testing against 3.13; when I tried to change
meta.yamlto prevent that, the build broke in a mysterious way.