Pin GitHub actions #113
Open
Pin GitHub actions #113
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
ci/pin-gha
branch
from
7821d91 to
e1d9e0e
Compare
edgarrmondragon
requested review from
henryiii and
utgwkk
and removed request for
henryiii
edgarrmondragon
force-pushed
the
ci/pin-gha
branch
2 times, most recently
from
b890b82 to
9aa0f49
Compare
edgarrmondragon
force-pushed
the
ci/pin-gha
branch
from
9aa0f49 to
ffd2b8a
Compare
edgarrmondragon
force-pushed
the
ci/pin-gha
branch
from
ffd2b8a to
45afa8e
Compare
Contributor
|
Okay if you want to, but I'm personally not a fan of pinning GHA. The reason is that the underlying images are fluid, and change regularly. Pinning can actually break actions, because the underlying image updates something (powershell, or the artifact system being two recent examples), causing the pinned version to fail when a looser version would actually have passed due to fixes being applied. I only like pinning less well maintained actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.