-
Notifications
You must be signed in to change notification settings - Fork 167
fix(tests): replace runpytest_subprocess with runpytest #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(tests): replace runpytest_subprocess with runpytest #1275
Conversation
92e141d to
3dae79c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the initiative!
The changes don't quite satisfy all tests. Unfortunately, simply replacing calls to runpytest_subprocess with runpytest is not sufficient. In the past, it was necessary to disable assertion rewriting for some of the tests. I haven't looked at the test errors in this PR in detail, so the solution here may be different.
@joao-faria-dev Could you have another look?
4987cec to
22fa51c
Compare
- runpytest_subprocess uses system-installed pytest-asyncio instead of development version, causing typeerror when tests needs to use loop_scope parameter
- Add pytester.makeini() calls to ensure asyncio_default_fixture_loop_scope is properly configured in test directories
ea5e8ef to
f99b678
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1275 +/- ##
==========================================
+ Coverage 90.53% 93.68% +3.15%
==========================================
Files 2 2
Lines 412 412
Branches 45 45
==========================================
+ Hits 373 386 +13
+ Misses 30 20 -10
+ Partials 9 6 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I pushed two commits to fix another couple of tests. Locally, I see In my opinion, the best way to address the deprecation warnings is to run the tests with These steps need to be done conditionally, though, because they only apply to Python 3.14. |
Related issue
Closes #1227
Description
Runpytest_subprocess uses system-installed pytest-asyncio instead of development version, causing typeerror when tests needs to use loop_scope parameter. This PR replaces the usage of Runpytest_subprocess in favor of runpytest