Fix get_data_yahoo() Bug in windows when start date is earlier than 1970-1-1 8:00
#846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 1970-1-1 8:00
Bug reproduce:
``` python3
from pandas_datareader import data as web
web.get_data_yahoo("IBM", start='1968-02-28', end='2020-02-08', interval="d")
```
ERROR `Overflow error: mktime argument out of range`
… occurrence of `OverflowError: mktime argument out of range`.
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==========================================
- Coverage 64.36% 63.79% -0.57%
==========================================
Files 62 62
Lines 2848 2848
Branches 305 305
==========================================
- Hits 1833 1817 -16
- Misses 939 957 +18
+ Partials 76 74 -2
Continue to review full report at Codecov.
|
… occurrence of `OverflowError: mktime argument out of range`.
ice-tong
changed the title
get_data_yahoo() Bug in windows when satrt date is earlier than 1970-1-1 8:00get_data_yahoo() Bug in windows when start date is earlier than 1970-1-1 8:00
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
==========================================
- Coverage 64.14% 63.79% -0.35%
==========================================
Files 65 62 -3
Lines 2906 2848 -58
Branches 311 305 -6
==========================================
- Hits 1864 1817 -47
+ Misses 967 957 -10
+ Partials 75 74 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
get_data_yahoo()Bug in windows when satrt date is earlier than 1970-1-1 8:00Bug reproduce:
ERROR
Overflow error: mktime argument out of rangegit diff upstream/master -u -- "*.py" | flake8 --diffblack --check pandas_datareader