This repository was archived by the owner on Dec 16, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 126
Fix potential compatibility issue with other libraries #440
Open
laysent
wants to merge
8
commits into
preactjs:master
Choose a base branch
from
laysent:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1c05330
improve fix for #423
laysent c0a3d3a
remove usage of .bind with additional parameter
laysent 189bbab
use .apply to replace .bind
laysent 7ebe074
fix eslint issue
laysent be7eb5e
Merge branch 'master' into master
developit 23a4231
Revert "use .apply to replace .bind"
laysent c3ac3b5
Revert "remove usage of .bind with additional parameter"
laysent 7a5722f
Merge branch 'master' into master
developit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the tests aren't failing, but I think this is missing an argument?
That would seem to be setting
thisto"div"in createElement.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I guess this implementation is wrong.
I could think of some ugly but correct implementation such as
createElement.apply(null, [type].concat(Array.apply(null, arguments))).In general, that's probably a bad idea and should not be merged. I will send another pr if I come up with some better idea.