Fix issue where copying bullets from the resulting pdf results in text with no whitespace and add cvsubitems
#525
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t with no whitespace and add `cvsubitems` This solution is based on @chelseanbr's comment from July 28, 2023, posquit0#71 (comment). Additionally this PR creates a new environment `cvsubitems`, that is functionally the same as `cvitems`, with the same workaround to allow reliable copypasting and parsing by ATS systems, but without some adjustments to vertical space that only make sense for `cvitems` ## Test Plan: 1. run `make` 2. Open all resulting PDFs and copy text from bullet points into a text editor, review that the copied text has spaces as expected. 3. Add a `cvsubitems` environment to the first `cventry` in experience to test that this also works as expected 4. Do the same copypaste test on `cv.pdf`, guaranteeing that we copy the subitems text.
|
why has @posquit0 not accepted this pull request? and 57 others? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution is based on @chelseanbr's comment from July 28, 2023, #71 (comment).
Additionally this PR creates a new environment
cvsubitems, that is functionally the same ascvitems, with the same workaround to allow reliable copypasting and parsing by ATS systems, but without some adjustments to vertical space that only make sense forcvitemsThis fixes #137
Test Plan:
makecvsubitemsenvironment to the firstcventryin experience to test that this also works as expectedcv.pdf, guaranteeing that we copy the subitems text.