Support python 3.11, fix bug in CodeType arg order #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an import failing when trying to run my
cpppocode in python 3.11:I looked into this and it looked like there was some python-version-specific code in
misc.py.In addition to adding support for python version 3.11, I also noticed what I think is a bug in the existing code. If you run
help(types.CodeType)in a python 3.8, 3.9, or 3.10 shell, you'll see that the second argument tocodeisposonlyargcount, but in the current code it is assumed to bekwonlyargcount. I fixed that in this PR as well.I tested this by running the import in python versions 3.7, 3.9, 3.10, and 3.11. I did not test in python 2.
It would be cool if someone with more knowledge of this code than me could kill this function entirely! Also I didn't see any CONTRIBUTING docs, so apologies if I'm doing this wrong. Thank you!