-
Notifications
You must be signed in to change notification settings - Fork 721
Fix: Send raw headers in HTTP response #1327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Raw headers added via addRaw() were not being sent in the response. The writeHeaders() function only wrote parsed headers from headers.list() but skipped headers from headers.rawList(). This fix adds a loop to write raw headers after the parsed headers.
|
Fix: Send raw headers in HTTP response ProblemRaw headers added via Root CauseThe SolutionAdded a loop to write raw headers after the parsed headers, ensuring all headers (both parsed and raw) are |
|
Thank you for your contribution, @hdmunguia. I'm going to discuss with my peers and we'll get back to you. In the mean time, please remember to bump the patch version. |
|
Hi! Could you please add a test case demonstrating the old behaviour, and how your patch fixes it? Thanks! |
|
Test changes pushed. Confirmed test case fails if fix is commented out. |
I think you forgot to push those changes, as I don't see the unit test or versioning changes. |
This test demonstrates that raw headers added via addRaw() are now correctly sent in HTTP responses. Without the fix, this test fails. With the fix, it passes.
|
You're still missing the versioning change previously discussed. |
|
I've updated version.txt and pushed. I hope this is the proper process. |
|
Unfortunately still not correct. Please read the documentation linked above since you've updated the implementation without adding or changing any interfaces. |
Raw headers added via addRaw() were not being sent in the response.
The writeHeaders() function only wrote parsed headers from headers.list()
but skipped headers from headers.rawList().
This fix adds a loop to write raw headers after the parsed headers.