Skip to content

[DNM] Release-8.5-cse #12354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: release-8.5
Choose a base branch
from
+4 −4
Draft

[DNM] Release-8.5-cse #12354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53b061c
minSyncPointInterval to 1s
pingyu Oct 4, 2025
fa30305
hack StatusIsEOF
pingyu Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cdc/kv/shared_stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,9 @@ func (s *requestedStream) receive(
zap.String("addr", rs.storeAddr),
zap.String("code", grpcstatus.Code(err).String()),
zap.Error(err))
if sharedconn.StatusIsEOF(grpcstatus.Convert(err)) {
return nil
}
// if sharedconn.StatusIsEOF(grpcstatus.Convert(err)) {
// return nil
// }
return errors.Trace(err)
}
if len(cevent.Events) > 0 {
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/replica_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import (

const (
// minSyncPointInterval is the minimum of SyncPointInterval can be set.
minSyncPointInterval = time.Second * 30
minSyncPointInterval = time.Second * 1
Copy link

@gemini-code-assist gemini-code-assist bot Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Changing minSyncPointInterval to 1 second breaks the unit test TestValidateAndAdjust in pkg/config/replica_config_test.go. Specifically, the assertion at line 277, require.Error(t, cfg.ValidateAndAdjust(sinkURL)), will fail because an interval of 29 seconds is now valid. Please update the test to align with this new minimum value.

// minSyncPointRetention is the minimum of SyncPointRetention can be set.
minSyncPointRetention = time.Hour * 1
minChangeFeedErrorStuckDuration = time.Minute * 30
Expand Down
Loading