standard: Make strcoll() use PATH ZPP #20498
Conversation
|
looks to me strcoll is purposely not binary safe, at least is self-aware of it according to the docs. Kind of BC changes ? |
| ZEND_PARSE_PARAMETERS_START(2, 2) | ||
| Z_PARAM_STR(s1) | ||
| Z_PARAM_STR(s2) | ||
| Z_PARAM_PATH_STR(s1) |
There was a problem hiding this comment.
we probably need 2 test cases at least.
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
As said in private, I wonder if it isn't better to deprecate locale aware string compares in general. As this also affects the sort functions using SORT_LOCALE_STRING as it calls string_locale_compare_function() which also truncates at the first nul byte.
And while this is dumb, it is documented on the manual and has been for ages. And there are some other functions that are documented to not be binary safe (crypt(), SQLite3::escapeString(), and error_log() from a quick source search of the note and text). So if we do it for this function I'd wager we should do it for the other ones that we control.
3 participants
No description provided.