ENH: use TimeSeries_DateFormatter in bar plot #62992
Draft
+49
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (GH#1918) Bar plots now use TimeSeries_DateFormatter for datetime and period indices, matching the formatting behavior of line plots. This provides consistent date formatting across different plot types. Changes: - Modified BarPlot._post_plot_logic() to detect time series indices - Convert DatetimeIndex to PeriodIndex for consistent formatting - Apply format_dateaxis() for proper date label formatting - Added test to verify bar plots use TimeSeries_DateFormatter - Updated secondary legend tests to use 'D' frequency instead of deprecated 'B' 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR enhances bar plots with datetime/period indices to use the TimeSeries_DateFormatter, matching the formatting behavior of line plots. This addresses issue #1918 where bar plots previously converted datetime indices to strings, losing the dynamic date formatting capabilities.
Key changes:
- Modified
BarPlot._post_plot_logic()to detect time series indices and apply date formatting - Updated test cases to use "D" (daily) frequency instead of "B" (business day) frequency
- Added a new test to verify the correct formatter is applied to bar plots with datetime indices
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pandas/plotting/_matplotlib/core.py | Added time series detection and date formatter logic to BarPlot._post_plot_logic(), importing decorate_axes function |
| pandas/tests/plotting/test_datetimelike.py | Changed test frequencies from "B" to "D" and added new test for bar plot date formatter |
| doc/source/whatsnew/v3.0.0.rst | Added changelog entry documenting the new behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…s (GH#1918) Bar plots now use TimeSeries_DateFormatter for datetime and period indices, matching the behavior of line plots. This provides consistent date formatting across different plot types instead of converting indices to string labels. Also update test_memory_leak to use 'D' (daily) frequency instead of deprecated 'B' (business day) frequency to avoid FutureWarning. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
fangchenli
force-pushed
the
fix/issue-1918-bar-plot-dateformatter
branch
from
33fdcc1 to
54edf6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.