TST: Improve runtime of some unit tests #62968
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Nov 4, 2025
| warning_type = DtypeWarning | ||
| # Use larger size to hit warning path | ||
| size = 499999 | ||
| size = heuristic - 1 |
There was a problem hiding this comment.
the comment above makes me think in this case size was made bigger. now you're making it smaller. am i interpreting the comment wrong?
There was a problem hiding this comment.
Fair point, the comment becomes outdated with this change. I'll update it.
For reference, I'm using the same technique used in the test above, test_chunks_have_consistent_numerical_type, to patch DEFAULT_BUFFER_HEURISTIC so we don't have to run a test with so much data to hit a condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pytest.mark.slowtopandas/tests/indexing/multiindex/test_indexing_slow.pytest_read_csv_memory_growth_chunksizeremoved as it's already covered by an ASVReadCSVMemoryGrowthtest_memory_leakmore specific to checking a reference cycle