Skip to content

Conversation

@phofl
Copy link
Member

@phofl phofl commented Nov 2, 2025

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Reviving an old PR of mine

phofl and others added 7 commits March 23, 2024 21:12
@phofl phofl requested a review from Dr-Irv as a code owner November 2, 2025 18:05
Comment on lines 339 to 342
* inner: use intersection of keys from both frames, similar to a SQL inner
join; preserve the order of the left keys.
* left_semi: Filter for rows in the left that have a match on the right;
preserve the order of the left keys.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sound really similar. I think the difference is that if a key appears more than once on the left, then only one match is returned. Secondly, no columns from the right are returned. Did I get that right? If so, I think you may want to say more here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is modeled after what a database semi join does. I can refer to that but I really don’t want to get too deep into the semantics here since there is a standard out there that defines this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Copy link
Contributor

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let others do a code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants