feat: Add component validation instructions #686
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the parser specification guarantees that PURL components are output in normalized form (at least for non–type-specific rules). However, the serializer specification assumes that components may originate from external sources and therefore be invalid or unnormalized. This leads to duplication, since both the parser and serializer repeat the same normalization and validation steps. This draft PR introduces a dedicated section that defines basic normalization and validation routines. These routines can be reused across: * PURL parser instructions * PURL serializer instructions * Implementations that construct PURL objects directly from components At this stage, the routines are presented in a standalone section. I have not yet integrated them into the parser and serializer instructions, pending feedback on their form (e.g., a simple list of rules vs. named routines similar to [WHATWG URL](https://url.spec.whatwg.org/#idna)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the parser specification guarantees that PURL components are output in normalized form (at least for non–type-specific rules). However, the serializer specification assumes that components may originate from external sources and therefore be invalid or unnormalized. This leads to duplication, since both the parser and serializer repeat the same normalization and validation steps.
This draft PR introduces a dedicated section that defines basic normalization and validation routines. These routines can be reused across:
At this stage, the routines are presented in a standalone section. I have not yet integrated them into the parser and serializer instructions, pending feedback on their form (e.g., a simple list of rules vs. named routines similar to WHATWG URL).