fix: eliminate non-posix standard variables

[airween]

what

This PR fixes the error that ./build.sh gives namely the src/Makefile.am contains non-POSIX variables.

why

GNU automake does not support wildcard, but the project uses that in src/Makefile.am. There is an open issue about this so we should fix that.

references

#3435
https://www.gnu.org/software/automake/manual/html_node/Wildcards.html

fix

As the documentation says above GNU automake expects a programmer should list the files instead of using wildcard, I used a hack: in build.sh I collect all header files in previously mentioned directories, and generate a file: src/headers.mk. This file is included in src/Makefile.am. The file is generated all cases when user runs ./build.sh. The generated file is not part of the source tree - see .gitignore changes in this PR.

[fzipi]

Typo

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[fzipi]

Two questions:

• why do you need to distribute these? https://github.com/owasp-modsecurity/ModSecurity/blob/v3/master/src/Makefile.am#L37-L58
• isn't your change being captured by https://github.com/owasp-modsecurity/ModSecurity/blob/v3/master/src/Makefile.am#L70-L85 ?

[airween]

• why do you need to distribute these? https://github.com/owasp-modsecurity/ModSecurity/blob/v3/master/src/Makefile.am#L37-L58

These are part of ModSecurity's API (the header files which will be installed under /usr/include/modsecurity) and I think make knows from these lines what headers need to install.

• isn't your change being captured by https://github.com/owasp-modsecurity/ModSecurity/blob/v3/master/src/Makefile.am#L70-L85 ?

I'm not sure I understand your question here, but yes, these lines are problematic. See the diff of the mentioned file. That's the point: eliminate the wildcard macro.