UCT/CUDA_IPC: Enforce host memory support for mem_type EP #10933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvegas1
reviewed
Oct 16, 2025
|
|
||
| if ((getpid() == *(pid_t*)params->iface_addr) && same_uuid && | ||
| !iface->config.enable_same_process) { | ||
| if ((getpid() == *(pid_t*)params->iface_addr) && same_uuid) { |
There was a problem hiding this comment.
now we will always prevent cuda_ipc from same process. is that what we want? if not maybe:
if ((getpid() == *(pid_t*)params->iface_addr) && same_uuid) {
return uct_iface_scope_is_reachable(tl_iface, params);
}
There was a problem hiding this comment.
actually this block will be removed all together but as this PR is not yet ready, some things is not commited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enforce host memory support for mem_type EP
Why?
Prevent cuda_ipc from being selected for mem_type EP