Skip to content

Make max number of subnet mechanisms configurable #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: devnet-ready
Choose a base branch
from
Open

Make max number of subnet mechanisms configurable #2183

wants to merge 7 commits into from
+86 −4

Conversation

@gztensor
Copy link
Contributor

@gztensor gztensor commented Nov 5, 2025

Description

Add admin extrinsic to set max number of subnet mechanisms.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor self-assigned this Nov 5, 2025
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Nov 5, 2025
JohnReedV
JohnReedV previously approved these changes Nov 5, 2025
View reviewed changes
camfairchild
camfairchild previously approved these changes Nov 5, 2025
View reviewed changes
l0r1s
l0r1s reviewed Nov 5, 2025
View reviewed changes
Copy link
Collaborator

@l0r1s l0r1s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to have a few unit tests, wdyt?

@gztensor gztensor marked this pull request as draft November 12, 2025 16:18
@gztensor gztensor dismissed stale reviews from camfairchild and JohnReedV via 33a4192 November 12, 2025 16:51
@gztensor gztensor marked this pull request as ready for review November 12, 2025 18:14
l0r1s
l0r1s requested changes Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@l0r1s l0r1s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be reset on dereg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l0r1s l0r1s l0r1s requested changes

@sam0x17 sam0x17 sam0x17 approved these changes

@camfairchild camfairchild camfairchild left review comments

@JohnReedV JohnReedV JohnReedV left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@gztensor gztensor

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gztensor @sam0x17 @camfairchild @l0r1s @JohnReedV