feat: add OperatorClusterURL and CustomFQDN support #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new configuration fields to support custom cluster URLs and FQDNs: - OperatorClusterURL: allows specifying a custom cluster URL - CustomFQDN: enables custom fully qualified domain names These fields provide flexibility for different deployment scenarios and networking configurations. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Implement utility function to generate cluster URLs with support for the new OperatorClusterURL configuration. Includes comprehensive tests to verify URL generation logic. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Update URLForCluster function to utilize the new OperatorClusterURL field when available. Includes tests to verify the integration works correctly with both default and custom URL configurations. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Extend TLS certificate generation to support custom FQDNs through the CustomFQDN field. This enables proper certificate validation for custom domain configurations. Includes comprehensive tests covering various FQDN scenarios. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Add Helm chart documentation, configuration examples, and user guide improvements for the new OperatorClusterURL and CustomFQDN features. Includes practical examples showing how to configure custom cluster URLs and domain names in different deployment scenarios. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Consolidate URL generation logic to eliminate code duplication and improve maintainability. Move shared functionality to helper functions and update tests accordingly. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Refactor TLS configuration code for better readability and maintainability. Simplify logic flow and improve error handling. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Move utility tests from util package to helpers package for better organization and clearer separation of concerns. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Update documentation to reference the current version for accuracy and consistency across all documentation files. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Replace placeholder comment with descriptive documentation for DashboardsTlsConfig TlsCertificateConfig field. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com> Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Add comprehensive tests for the new ClusterURL helper function: - Test custom operatorClusterURL usage - Test default internal DNS fallback - Test default port handling Tests are added to the existing helpers test structure from main branch. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
|
There seems to be a failing test can you pleaes review? @josedev-union can you have a look too please? |
The test was expecting port 0 when HttpPort is not set, but the ClusterURL function correctly defaults to port 9200 when HttpPort is 0. Updated the test expectation to match the correct behavior. Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
Signed-off-by: Jonathan Schwarze <jonathan.schwarze@sap.com>
josedev-union
suggested changes
Oct 28, 2025
There was a problem hiding this comment.
@joluc followings are missing in your PR
- regenerate
opensearchclustersCRD - regenerate deepcopy file
you can get them running
make generate
make build manifests
github-project-automation
bot
moved this to 👀 In Review
in Engineering Effectiveness Board
|
@joluc can you please fix DCO issue and resolve conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for configuring a custom URL for operator-to-cluster communication, resolving the issue where the operator cannot connect to OpenSearch clusters using LoadBalancer services with external TLS certificates.
Key Features
Use Cases
Issues Resolved
#1146
Check List
make lint)If CRDs are changed:
make manifests) and also copied into the helm chartPlease refer to the PR guidelines before submitting this pull request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.