Skip to content

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented Nov 11, 2025

Could I have review of a clean backport?

Testing: tier1 + test/jdk/dk/jfr

Thanks
Erik

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8370242 needs maintainer approval

Issue

  • JDK-8370242: JFR: Clear event reference eagerly when using EventStream (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/372/head:pull/372
$ git checkout pull/372

Update a local copy of the PR:
$ git checkout pull/372
$ git pull https://git.openjdk.org/jdk25u.git pull/372/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 372

View PR using the GUI difftool:
$ git pr show -t 372

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/372.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2025

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 65b32394187988abab99a8017eda39b1bd4a1782 8370242: JFR: Clear event reference eagerly when using EventStream Nov 11, 2025
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 11, 2025
@egahlin egahlin marked this pull request as ready for review November 11, 2025 15:51
@openjdk
Copy link

openjdk bot commented Nov 11, 2025

⚠️ @egahlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 11, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2025

Webrevs

@egahlin
Copy link
Member Author

egahlin commented Nov 12, 2025

/label add hotspot-jfr

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@egahlin
The label hotspot-jfr is not a valid label.
These labels are valid:

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants