Skip to content

Conversation

@signedav
Copy link
Member

@signedav signedav commented Oct 7, 2025

Current implementation

This PR introduces process algorithms for data import / export / validate with ili2pg and ili2gpkg:

image

They contain all the settings provided by the Model Baker Plugin:

image

Path through

The input parameters concerning the database connection are passed through as output parameters, means you can easily connect these algorithms in the graphical modeler:

image

Situation with the input parameter

While we have at the moment just a plain list of input parameters, this is not that comfy to use when starting the algorithms directly. As well it would make sense to have an option to read the connection parameters (like we do it in model baker) from a layer. But not only. It should be optional to enter manually, read from layer or use an existing db connection (defined in the data source manager).

An option would be to create two more algorithms:

  • parsing connection params from layer
  • parsing connection params from profile db connection

But even nicer would be an almighty input parameter:

image

(Source: https://excalidraw.com/#json=vzYp9UoP3hOo3p19Iz7-e,He6nXlycWuRxn3h42DXUeQ )

But:

  • Because this input parameter would make sense to introduce from the beginning, it would make sense to have it in (this would go over budget)
  • But otherwise we would need multiple algorithms - old versions / new versions etc. that would be a mess...

Desicion

We decided against having this almighty input parameter, because it's very inflexible in the modeler. We would loose all the flexibility in getting the connection parameters. This is why in the end another "meta-algorithm" is part of the solution. Parsing connection params from layer (like mentioned above):

With this, such models can be built:

image

processingexample.zip

Choosing an input layer, deciding according to provider what algorithm should be run and pass the parsed connection settings.

To Do

  • Import PG
  • Import GPKG
  • Validate PG
  • Validate GPKG
  • Export PG
  • Export GPKG
  • Test PG with Baskets
  • Test PG without Baskets
  • Test GPKG with Baskets
  • Test GPKG without Baskets
  • Image
  • shortDescription/shortHelpString(self) in ValidatingAlgorithms
  • super users
  • db params are concerned
  • Concept for a better input parameter

@signedav signedav marked this pull request as ready for review October 31, 2025 15:55
@signedav signedav requested a review from gacarrillor October 31, 2025 15:56
@signedav
Copy link
Member Author

@gacarrillor what do you think about the decision with the meta algorithms in the end (after you pointed to the fact, that it's not super nice). I'm at the moment quite happy with the solution, but still open for other opinions.

If it's fine for you, then your review is appreciated. Thanks 🎃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants