OBLS-284 allow to edit product barcode (upc) #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiranda
requested changes
Nov 10, 2025
Member
jmiranda
left a comment
jmiranda
left a comment
There was a problem hiding this comment.
Small change to the API URL. Need @awalkowiak to look at the react code.
| } | ||
|
|
||
| export function updateProductBarcode(id: string, barcode: string) { | ||
| return apiClient.put(`/mobile/products/${id}/barcode`, { upc: barcode }); |
Member
There was a problem hiding this comment.
Do something like this to make it more generic. Eventually, we'll add more properties to identifier, like type. The fact that we're mapping it to UPC right now is an implementation detail. We don't actually want to map it to this field in the long-run.
/api/products/${id}/identifiers { identifier: identifier }
awalkowiak
approved these changes
Nov 13, 2025
Collaborator
awalkowiak
left a comment
awalkowiak
left a comment
There was a problem hiding this comment.
Looks good to me. After changing the api url and endpoint this can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openboxes.atlassian.net/browse/OBLS-284
Changes:
edit barcodemodal