Skip to content

Conversation

@maryliag
Copy link
Contributor

@maryliag maryliag commented Oct 24, 2025

Start to use configuration package on sdk-node.
For now is a basic usage, just to get feedback on implementation. Things should work normally without changes.

Using values for sdk disable, log level, and resource attributes from config model

@maryliag maryliag requested a review from a team as a code owner October 24, 2025 03:48
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.17%. Comparing base (74f470e) to head (3d0cfb5).

Files with missing lines Patch % Lines
...ental/packages/opentelemetry-sdk-node/src/utils.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6044   +/-   ##
=======================================
  Coverage   95.16%   95.17%           
=======================================
  Files         316      317    +1     
  Lines        9198     9216   +18     
  Branches     2057     2060    +3     
=======================================
+ Hits         8753     8771   +18     
  Misses        445      445           
Files with missing lines Coverage Δ
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 95.21% <100.00%> (-0.83%) ⬇️
...tal/packages/opentelemetry-sdk-node/src/semconv.ts 100.00% <ø> (ø)
...ental/packages/opentelemetry-sdk-node/src/utils.ts 94.16% <90.90%> (+1.85%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review - I did not have a detailed look at this PR yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants