-
Notifications
You must be signed in to change notification settings - Fork 62
feat: flagd provider creates named daemon threads for error executor #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jarebudev
wants to merge
4
commits into
open-feature:main
Choose a base branch
from
jarebudev:1599_flagd_threads
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+79
−2
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9ec5193
flagd provider creates named daemon threads for error executor
jarebudev 4a85e24
removed public modifier
jarebudev 4d400c1
Merge branch 'main' into 1599_flagd_threads
jarebudev 8a32d3b
applied suggested change for checking namePrefix param is not null
jarebudev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
...iders/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdThreadFactory.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package dev.openfeature.contrib.providers.flagd; | ||
|
|
||
| import java.util.Objects; | ||
| import java.util.concurrent.ThreadFactory; | ||
| import java.util.concurrent.atomic.AtomicInteger; | ||
|
|
||
| /** | ||
| * Thread factory for the Flagd provider to allow named daemon threads to be created. | ||
| */ | ||
| class FlagdThreadFactory implements ThreadFactory { | ||
|
|
||
| private final AtomicInteger counter = new AtomicInteger(); | ||
| private final String namePrefix; | ||
|
|
||
| /** | ||
| * {@link FlagdThreadFactory}'s constructor. | ||
| * | ||
| * @param namePrefix Prefix used for setting the new thread's name. | ||
| */ | ||
| FlagdThreadFactory(String namePrefix) { | ||
| this.namePrefix = Objects.requireNonNull(namePrefix, "namePrefix must not be null"); | ||
| } | ||
|
|
||
| @Override | ||
| public Thread newThread(Runnable runnable) { | ||
| final Thread thread = new Thread(runnable); | ||
| thread.setDaemon(true); | ||
| thread.setName(namePrefix + "-" + counter.incrementAndGet()); | ||
| return thread; | ||
| } | ||
| } |
46 changes: 46 additions & 0 deletions
46
...s/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/FlagdThreadFactoryTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| package dev.openfeature.contrib.providers.flagd; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class FlagdThreadFactoryTest { | ||
|
|
||
| private static final String THREAD_NAME = "testthread"; | ||
| private final Runnable runnable = () -> {}; | ||
|
|
||
| @Test | ||
| void verifyThreadFactoryThrowsNullPointerExceptionWhenNamePrefixIsNull() { | ||
|
|
||
| // Then | ||
| var exception = assertThrows(NullPointerException.class, () -> { | ||
| // When | ||
| new FlagdThreadFactory(null); | ||
| }); | ||
| assertThat(exception.toString()).contains("namePrefix must not be null"); | ||
| } | ||
|
|
||
| @Test | ||
| void verifyNewThreadHasNamePrefix() { | ||
|
|
||
| var flagdThreadFactory = new FlagdThreadFactory(THREAD_NAME); | ||
| var thread = flagdThreadFactory.newThread(runnable); | ||
|
|
||
| assertThat(thread.getName()).isEqualTo(THREAD_NAME + "-1"); | ||
| assertThat(thread.isDaemon()).isTrue(); | ||
| } | ||
|
|
||
| @Test | ||
| void verifyNewThreadHasNamePrefixWithIncrement() { | ||
|
|
||
| var flagdThreadFactory = new FlagdThreadFactory(THREAD_NAME); | ||
| var threadOne = flagdThreadFactory.newThread(runnable); | ||
| var threadTwo = flagdThreadFactory.newThread(runnable); | ||
|
|
||
| assertThat(threadOne.getName()).isEqualTo(THREAD_NAME + "-1"); | ||
| assertThat(threadOne.isDaemon()).isTrue(); | ||
| assertThat(threadTwo.getName()).isEqualTo(THREAD_NAME + "-2"); | ||
| assertThat(threadTwo.isDaemon()).isTrue(); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string literal
"flagd-provider-thread"is duplicated on line 108. To improve maintainability and avoid magic strings, consider extracting it into aprivate static finalconstant at the class level. For example:private static final String ERROR_EXECUTOR_THREAD_NAME_PREFIX = "flagd-provider-thread";