Skip to content

Conversation

@Griger5
Copy link
Collaborator

@Griger5 Griger5 commented Nov 7, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.69%. Comparing base (da95a8d) to head (56a469d).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/json_resource.hpp 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files          55       55           
  Lines        2537     2537           
  Branches      144      144           
=======================================
  Hits         2301     2301           
  Misses        163      163           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Griger5 Griger5 marked this pull request as ready for review November 7, 2025 13:05
@Griger5 Griger5 requested a review from slayoo November 7, 2025 13:05
@slayoo slayoo changed the title Replace nlohmann::json with nlohmann::ordered_json to maintain order in input/output Replace nlohmann::json with nlohmann::ordered_json to maintain order in input/output. Closes #213 Nov 9, 2025
@slayoo slayoo changed the title Replace nlohmann::json with nlohmann::ordered_json to maintain order in input/output. Closes #213 Replace nlohmann::json with nlohmann::ordered_json to maintain order in input/output. Bumps nanobind_json submodule. Closes #213 Nov 9, 2025
@slayoo slayoo added this pull request to the merge queue Nov 9, 2025
Merged via the queue into open-atmos:main with commit 1490a37 Nov 9, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants