-
-
Notifications
You must be signed in to change notification settings - Fork 361
plugins/gitportal: init #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/gitportal: init #3935
Conversation
GaetanLepage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! Welcome on board!
This PR is on a very good way.
A few initial remarks:
- You don't have to declare the
settingsOptions. We tend to move away from this assettingsis already a freeform option. This means that it accepts arbitrary values and automatically converts them to lua. This reduces future maintenance. - Please split your patch into two commits:
maintainers: add phinzeplugins/gitportal: init
|
Hi @GaetanLepage thanks for the quick review! Based on the build failures it looks like I misunderstood and jumped the gun - this needs to be submitted to nixpkgs first. Will convert to draft until I can sort that out. 👍🏻 |
Yes, if the plugin is not packaged there, you first need to open a PR to add it. |
5daa157 to
e5fa242
Compare
|
Ok! Upstream has merged and I believe I've addressed the feedback. The build failures should go green on the next scheduled flake update. |
83c49d9 to
7079a87
Compare
|
Rebased over the current update branch from #3934 and fixed an issue and now CI is looking good - once that lands the base branch should automatically switch to |
d116f3b to
36bef23
Compare
Apparently it didn't work ^^ Please, re-submit a PR. |

👋 Hey there! This is my first contribution to nixvim - please let me know if I missed anything or if there are any improvements I should make!
Summary
Add support for gitportal.nvim, a plugin that bridges Neovim and Git hosting platforms.
What does this plugin do?
GitPortal enables users to:
Changes in this PR
always_include_current_line- Always include the current line in URLsalways_use_commit_hash_in_url- Use commit hash instead of branch namebrowser_command- Custom browser command (auto-detection if null)default_remote- Default git remote to use (defaults to "origin")git_provider_map- Custom mapping of git providersswitch_branch_or_commit_upon_ingestion- Behavior when ingesting permalinks ("always", "ask_first", or "never")Example Configuration
Testing