Skip to content

Conversation

@marshallwp
Copy link

@marshallwp marshallwp commented Oct 17, 2025

Proposed changes

The print logrotate error handler no longer fails if all errors are about rotation failing due to preexisting log files. If any of the errors are about something else, failure will occur as usual.

This resolves #913

Checklist

Before creating a PR, run through this checklist and mark each as complete:

…ing rotation

The print logrotate error handler no longer fails if *all* errors are about rotation failing due to preexisting log files.  If any of the errors are about something else, failure will occur as usual.

This resolves nginx#913
@marshallwp marshallwp requested a review from a team as a code owner October 17, 2025 20:48
@github-actions
Copy link

github-actions bot commented Oct 17, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added the bug Something isn't working label Oct 17, 2025
@marshallwp
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

Moved the edit down one line to the `failed_when` line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logrotate Handler Causes Role to Fail When Log Already Exists

1 participant