Add allow_msg_schedules to StreamConfig
#765
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Casper Beyer <casper@synadia.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the allow_msg_schedules configuration option to the StreamConfig class, enabling control over scheduled/delayed message functionality introduced in nats-server 2.12.0.
- Added
allow_msg_schedulesfield toStreamConfigclass - Added comprehensive test coverage for the new configuration option
- Included documentation comment explaining the feature and server version requirement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nats/src/nats/js/api.py | Added allow_msg_schedules optional boolean field to StreamConfig with documentation |
| nats/tests/test_js.py | Added test function covering True, False, and default (None) cases for allow_msg_schedules |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Casper Beyer <casper@synadia.com>
Signed-off-by: Casper Beyer <casper@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.