feat(editor): Add extra filtering params to dynamic banners request (no-changelog) #21313
+48
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Those are not yet hooked in the creators site backend but sending them already from the instances will allows us to target earlier versions when introduced there.
** Moved the banners store into the banners feature dir as discussed in previous PR
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-4314/feature-dynamic-banners
The params list requested by Paul:
https://www.notion.so/n8n/Filters-to-add-29a5b6e0c94f806fb0a6fc76321874f4?source=copy_link
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)