Skip to content

Conversation

@brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Oct 28, 2025

Related to #809.

Enabled for both linting and building packages

The idea is first to explore the changes required at the repo level and then abstract it out as required to be part of code-infra package.

The bundle size increases significantly with the compiler output. This is something that we'll need to discuss.

@brijeshb42 brijeshb42 requested a review from a team October 28, 2025 10:15
@brijeshb42 brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Oct 28, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 28, 2025

vite-css-base-ui-example

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@3076
pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@3076

commit: 3c0b18d

@mui-bot
Copy link

mui-bot commented Oct 28, 2025

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 🔺+121KB(+31.56%) 🔺+49.2KB(+40.43%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Oct 28, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 3c0b18d
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6901930030a52a0008d1197e
😎 Deploy Preview https://deploy-preview-3076--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@flaviendelangle
Copy link
Member

Some of the bundle increase can probably be compensated by removing all the redundant useMemo / useCallback that are no longer needed.
But I doubt it will enough, 40% increase is massive 😬

@Janpot
Copy link
Member

Janpot commented Oct 28, 2025

FYI: you can explore the output when following the links to the diff pages on https://frontend-public.mui.com/repository/mui/base-ui/prs/3076

Some of the bundle increase can probably be compensated by removing all the redundant useMemo / useCallback that are no longer needed.

Compiler removes them, but maybe some code can be simplified if memoization is not a concern anymore?

@atomiks
Copy link
Contributor

atomiks commented Oct 28, 2025

This also seems to break list navigation entirely (useListNavigation hook) used in Menu, Select, Combobox, etc

Enabled for both linting and building packages
@LukasTy
Copy link
Member

LukasTy commented Oct 30, 2025

Maybe we should start with enabling this only for linting?
Looks like realistically it's far from reality.

@LukasTy LukasTy mentioned this pull request Oct 31, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants