* ft: fetch validator info with public secp #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Arjun-Somvanshi
commented
Oct 23, 2025
Arjun-Somvanshi
commented
- ft: allow user to get val-id with public secp key
- docs: reflect changes in docs for cli
* ft: allow user to get val-id with public secp key * docs: reflect changes in docs for cli Signed-off-by: Arjun-Somvanshi <asomvanshi@category.xyz>
Arjun-Somvanshi
requested review from
a26nine,
bgrahammonf,
jadechip,
johnmarcou,
keone,
silviugae and
techgigs80
as code owners
johnmarcou
reviewed
Oct 23, 2025
Comment on lines
-212
to
+215
| "--validator-id", | ||
| type=int, | ||
| "--secp-pubkey", | ||
| type=str, | ||
| required=True, | ||
| help="Unique id representing the validator on-chain", | ||
| help="Compressed SECP public key of the validator, as generated by monad-keystore", |
Contributor
There was a problem hiding this comment.
question: Does this means we won't be able to query by validator ID after this change?
I think this feature is actually useful.
Collaborator
Author
There was a problem hiding this comment.
Yes, however if querying with val-id is useful we can keep both options available, the point here is to abstract val-id from the end user, eventually this eth_storage call wont be required and a sc call will be baked in to the staking contract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.