- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 57
 
adding downloadable flag to library list cmd #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
           @rhhayward  | 
    
        
          
                src/audible_cli/cmds/cmd_library.py
              
                Outdated
          
        
      | 
               | 
          ||
| books = await asyncio.gather( | ||
| *[_prepare_item(i) for i in library] | ||
| *[_prepare_item(i) for i in library if downloadable==False or i.is_downloadable()] | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of writing downloadable==False it should be downloadable is False.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code work as is. downloadable==False should be rewritten to downloadable is False.
| 
           @rhhayward  | 
    
| 
           Sure, I can do that. Here's what I'm thinking: and then I'll create flags based on the contents for   | 
    
| 
           @mkb79 - I've changed to the --filter format. Let me know what you think.  | 
    
…ard/audible-cli into library-list-downloadable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open another PR for the decrypt command code. Thank you!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The decrypt command should be implemented in another PR to better track changes.
Hi @mkb79,
I've taken a stab at adding a "--downloadable" flag for the library list command. I tried to duplicate the pattern of the existing "--resolve-podcasts" flag, but if there's a better way please let me know. I also had to add "customer_rights" to the response_groups list to populate the necessary field for the is_downloadable() function.
I also haven't tested this with podcasts, or other types of resources, so if there's tests you'd suggest please let me know.
Thanks,
rhhayward