Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 29, 2025

The ResourceName property in InputOperation was copied from autorest.csharp but is no longer used. Previously used for client naming, it has been replaced by other mechanisms and has no active references in the codebase.

Changes

  • InputOperation.cs: Removed property, constructor parameter, and Update method parameter
  • InputOperationConverter.cs: Removed JSON serialization/deserialization logic
  • operation-converter.ts: Removed property assignment and unused helpers (getOperationGroupName, getResourceOperation import)
  • input-operation.ts: Removed from TypeScript interface
  • InputFactory.cs: Updated test factory method signature

All changes are removal-only with no functional impact.

Original prompt

This section details on the original issue you should resolve

<issue_title>[http-client-csharp] remove property ResourceName in InputOperation</issue_title>
<issue_description>This ResourceName property was something that we copied from autorest.csharp repo, but now it makes no sense.
Previously we use this to determine the name of a client - now obviously we are using something else.
When I check the usage of this property, it is never used.
We should remove it.</issue_description>

<agent_instructions>Please work inside packages/http-client-csharp directory.
This package uses npm instead of pnpm.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits October 29, 2025 08:17
Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
Co-authored-by: ArcturusZhang <10554446+ArcturusZhang@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove ResourceName property in InputOperation Remove unused ResourceName property from InputOperation Oct 29, 2025
Copilot AI requested a review from ArcturusZhang October 29, 2025 08:27
Copilot finished work on behalf of ArcturusZhang October 29, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet