Skip to content

Conversation

@jahnvi480
Copy link
Contributor

@jahnvi480 jahnvi480 commented Oct 28, 2025

Work Item / Issue Reference

AB#38478


Summary

This pull request primarily refactors the formatting and structure of the mssql_python/pybind/ddbc_bindings.cpp file, focusing on code readability and maintainability. No functional logic changes are introduced; instead, the changes consist of improved line wrapping, consistent indentation, and clearer inline comments, especially in function definitions and pybind11 module bindings.

Formatting and readability improvements:

  • Reformatted function signatures and argument lists in several places (e.g., FetchMany_wrap, pybind11 bindings) for better readability and consistency.
  • Improved line wrapping and indentation in conditional logic and function calls, making code easier to follow.
  • Enhanced inline comments, especially around LOB streaming and module-level UUID caching, for clarity.
  • Updated error logging during ODBC driver loading to use multi-line comments and clearer formatting.

Header and include adjustments:

  • Reordered and deduplicated header includes, grouping standard library headers and removing redundant imports.

@github-actions github-actions bot added the pr-size: medium Moderate update size label Oct 28, 2025
@github-actions github-actions bot added pr-size: large Substantial code update and removed pr-size: medium Moderate update size labels Oct 28, 2025
@jahnvi480 jahnvi480 merged commit 87eb1f5 into jahnvi/encode_decode_250 Oct 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-size: large Substantial code update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants