CI/CD update: add a new workflow to test building all images; skip push specific images in alertmanager to GHCR; #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhogu
force-pushed
the
zhogu/cicd-build-all
branch
from
a616d16 to
898edd5
Compare
zhogu
force-pushed
the
zhogu/cicd-build-all
branch
from
898edd5 to
e3ca184
Compare
zhogu
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR introduces workflow improvements and fixes, including special handling for the alert-manager service, standardization of quote styles, and workflow deprecation updates.
- Removed alert-manager from the build-deploy-changes workflow filter and added custom logic to push only specific alert-manager images to GHCR
- Added a new workflow to build all services for comprehensive testing
- Fixed a typo in the Dockerfile chmod command approach and added kusto-sdk to .gitignore
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/build-deploy-changes.yaml | Removed alert-manager filter, added special handling for alter-manager (typo), standardized quote styles, and fixed indentation |
| .github/workflows/build-all.yaml | New workflow to build all services with error handling and reporting |
| src/cluster-local-storage/build/cluster-local-storage.common.dockerfile | Replaced COPY --chmod with separate RUN chmod command |
| src/alert-manager/.gitignore | Added kusto-sdk directory to ignore list |
| .github/CODEOWNERS | Added code ownership rules for the repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+124
to
+128
| # check whether alter-manager is in the changed services | ||
| echo "Changed services before removing alter-manager: $changed_services" | ||
| if [[ "$changed_services" == *"alter-manager"* ]]; then | ||
| echo "alter-manager is in the changed services" | ||
| changed_services=$(echo $changed_services | sed 's/alter-manager//g') |
There was a problem hiding this comment.
The service name is misspelled as 'alter-manager' but should be 'alert-manager' to match the actual service name used elsewhere in the codebase.
Suggested change
| # check whether alter-manager is in the changed services | |
| echo "Changed services before removing alter-manager: $changed_services" | |
| if [[ "$changed_services" == *"alter-manager"* ]]; then | |
| echo "alter-manager is in the changed services" | |
| changed_services=$(echo $changed_services | sed 's/alter-manager//g') | |
| # check whether alert-manager is in the changed services | |
| echo "Changed services before removing alert-manager: $changed_services" | |
| if [[ "$changed_services" == *"alert-manager"* ]]; then | |
| echo "alert-manager is in the changed services" | |
| changed_services=$(echo $changed_services | sed 's/alert-manager//g') |
| run: | | ||
| services=$(ls -1d src/* | awk -F'/' '{print $2}' | tr '\n' ' ') | ||
| echo "All services: $services" | ||
| echo "::set-output name=services::$services" |
There was a problem hiding this comment.
The 'set-output' command is deprecated in GitHub Actions. Use the newer syntax: echo "services=$services" >> $GITHUB_OUTPUT instead.
Suggested change
| echo "::set-output name=services::$services" | |
| echo "services=$services" >> $GITHUB_OUTPUT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.