-
Couldn't load subscription status.
- Fork 283
typescript: allow mixed types for anyOf
#6816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
show service level agreement |
|
@danaelhe Thanks for the contribution! I think you got really close with the agreement. Try
|
Thanks so much!! Just double checking with legal on our side. |
@microsoft-github-policy-service agree company="digitalocean" |
all good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Can you also add a changelog entry (unreleased, changed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes!
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes!
|
@danaelhe there are a number of languages integration tests that are failing. |
|
@danaelhe integration tests are still failing because of the union types. Would you mind having a look please? |
|
@danaelhe gentle reminder on the previous comment |
Described the bug here:
#6801 (comment)
Now it can properly handle anyOf (e.g. here) of mixed types.
Example OpenAPI 3.0 spec:
Now generates:
When before it was just allowing one type:
bySsh_key_identifier(ssh_key_identifier: number) : WithSsh_key_identifierItemRequestBuilder;Re-ran our mocked tests and it all seems to pass...doesn't seem to have broke anything else 🤞