-
Notifications
You must be signed in to change notification settings - Fork 7.5k
CmdPal: Restore CmdPal package dependency on VCRT #42658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CmdPal: Restore CmdPal package dependency on VCRT #42658
Conversation
|
To do: The PT installer should consider those dependencies |
|
Yop, current PTs installer won't include content of |
|
The AdaptiveCards.Rendering.WinUI3 library has supported Hybrid CRT since version 2.2.2-beta (we use 2.1.0-beta). While it was also added to AdaptiveCards.ObjectModel.WinUI3, it was never published to NuGet. |
|
Can we get the package in private feed? |
Hi @vanzue, They never released a package for the ObjectModel library. I’ve opened an issue in the AdaptiveCards repo requesting it, but I don’t expect a response anytime soon. I don’t think building it ourselves would be wise, so packaging the CRT with CmdPal seems like the way to go. I just need to get it building to verify the installer changes. |
|
OK! Let me pick installer code and spin a installer to test |
|
Ohh, I realize there are two vcruntime packed, do you know how we can just get our dependency to "Microsoft.VCLibs.140.00.Debug.UWPDesktop"? adpative card should only depend on this (our previous version only pack this package and it works) |
The PackageDependency can be added to manifests manually. WinUISDKReferences just looked like a cleaner solution (even through it adds both of them). might do the trick. Thanks for checking this out. I’ve finally managed to get the machine close to building the installer after a clean install of VS (looks like some weird interference between different VS2022, 2022 preview and 2026 instances 🤯), but now I’m facing just few linker errors in PT.sln and a few WIX00010 errors on the generated elements :/ |
Summary of the Pull Request
This PR restores the CmdPal's package dependency on the Microsoft Visual C++ Runtime (VCRT).
The change ensures that Adaptive Cards can be created and rendered correctly without requiring a separate VCRT installation.
Projected change to CmdPal's app package manifest:
Debug:
Release:
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed