-
Notifications
You must be signed in to change notification settings - Fork 270
Adding configuration in PO matching to receive at posting of the invoice #5303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...cument/App/src/Processing/Import/Purchase/PurchaseOrderMatching/EDocPOMConfiguration.Enum.al
Show resolved
Hide resolved
...Document/App/src/Processing/Import/Purchase/PurchaseOrderMatching/EDocPOMatching.Codeunit.al
Outdated
Show resolved
Hide resolved
...cument/App/src/Processing/Import/Purchase/PurchaseOrderMatching/EDocPOMatchingSetup.Table.al
Show resolved
Hide resolved
...cument/App/src/Processing/Import/Purchase/PurchaseOrderMatching/EDocPOMatchingSetup.Table.al
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
Summary
Implementation of configuration settings for what to do when getting a new invoice and the underlying matched order has not yet been marked as received. There are 5 different configurations a user can select, found in
EDocPOMConfiguration.Enum.al:Each of these affect the process of processing an invoice in the following ways:
Additionally an orthogonal setting to allow for receiving lines when they are of type G/L Account is also considered.
How the new settings affect the PO matching process
When first trying to match
When trying to match, we will prevent the match with an error if:
This happens in the procedure
MatchPOLinesToEDocumentLine.When deciding whether or not we should warn the user
We want to warn the user if the order has not been received only when the configuration is set to:
The logic for this is in the procedure
AppendPOMatchWarnings.When finalizing to create the final invoice
We want to ask the user if they want to continue in the following cases:
We want to error out in the following cases:
For the rest of the scenarios, we allow finalizing without user confirmation.
This happens in
EDocCreatePurchaseInvoice.Codeunit.al.Work Item(s)
Fixes AB#599135