Skip to content

Invoice Details for "Unit Cost Surcharge" #5280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Invoice Details for "Unit Cost Surcharge" #5280

wants to merge 5 commits into from

Conversation

@miljance
Copy link
Contributor

@miljance miljance commented Oct 22, 2025 •
edited by github-actions bot
Loading

Summary

  • Usage Data Billing now contains both Product ID and Product Name.
  • Introduced a setup field to control whether the Subscription Line Description or Product Name is printed on a Posted Sales Invoice for "Unit Cost Surcharge" scenario.
  • Updated Demo Data Creation to prevent duplicate Product Name values when fields are imported via Data Exchange Definition in Usage-Based Billing.

⚠️ Note: This pull request requires a technical code review. Please hold off on approval until the technical review is completed by @samra-singhammer.

Work Item(s)

Fixes #4485

@miljance miljance requested a review from a team as a code owner October 22, 2025 13:35
@github-actions github-actions bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Oct 22, 2025
samra-singhammer
samra-singhammer suggested changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@samra-singhammer samra-singhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Miljan, I've added couple of comments and questions. Please review them.

@miljance miljance requested a review from a team as a code owner October 23, 2025 13:24
@miljance miljance requested a review from pri-kise October 23, 2025 13:47
@djukicmilica djukicmilica added the Finance GitHub request for Finance area label Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pri-kise pri-kise pri-kise approved these changes

@samra-singhammer samra-singhammer samra-singhammer approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

AL: Apps (W1) Add-on apps for W1 Finance GitHub request for Finance area From Fork Pull request is coming from a fork

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Invoice details not accurate for usage data scenarios [SubscriptionBilling]

4 participants

@miljance @pri-kise @samra-singhammer @djukicmilica