fix: save and restore buffer mappings overridden by VM (#280) #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when VM encountered existing buffer-local mappings (e.g., from vim-remotions), it would skip creating its own mappings, causing motions to only work on the current cursor instead of all cursors. This commit implements a save-and-restore mechanism: - Saves existing buffer mappings before overriding them - Restores the original mappings when VM exits - Properly handles all mapping attributes (noremap, silent, expr, etc.) - Includes support for Neovim Lua callback mappings Fixes mg979#280 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when VM encountered existing buffer-local mappings (e.g., from vim-remotions), it would skip creating its own mappings, causing motions to only work on the current cursor instead of all cursors.
This commit implements a save-and-restore mechanism:
Fixes #280
🤖 Generated with Claude Code