Fix/add explicit admin dependencies #379
Open
+16
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add explicit dependencies for packages that were previously available only through transitive dependencies from @medusajs/dashboard: - @tanstack/react-query@5.64.2 - @dnd-kit/core@^6.3.1 - @dnd-kit/sortable@^8.0.0 - @dnd-kit/utilities@^3.2.2 - cmdk@^0.2.1 - react-router-dom@6.20.1 These packages are actively used in the admin interface but were not explicitly declared, creating a risk of breakage if upstream dependencies change. This change improves dependency transparency and stability.
Add apps/backend/public to .gitignore as it's a symlink automatically created during the build process pointing to .medusa/server/public/
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Add Explicit Dependencies for Admin Interface Packages
Problem
Our build process breaks because the admin interface imports packages that aren't explicitly declared in
apps/backend/package.json. These dependencies were only available through a transitive dependency chain:This creates TypeScript errors and potential build failures when the dependency chain changes.
Solution
Added explicit dependencies using the exact versions already resolved by Yarn:
{ "dependencies": { "@dnd-kit/core": "^6.3.1", "@dnd-kit/sortable": "^8.0.0", "@dnd-kit/utilities": "^3.2.2", "@tanstack/react-query": "5.64.2", "cmdk": "^0.2.1", "react-router-dom": "6.20.1" } }These packages are actively used throughout the admin interface (31+ files) for:
@tanstack/react-query)@dnd-kit/*)cmdk)react-router-dom)Additional Changes
Added
apps/backend/publicto.gitignore- this symlink is created during the build process.Impact