Skip to content

Conversation

@aksiome
Copy link
Member

@aksiome aksiome commented Oct 31, 2025

Description

This PR replaces the is_conductive and is_spawnable functions by predicates.

It also adds 3 new predicates related to redstone:

  • is_powered
  • is_strongly_powered
  • is_weakly_powered

and 3 new functions:

  • is_touching_power
  • is_touching_strong_power
  • is_touching_weak_power

It also reorganizes things slightly by moving internal .json files into an internal folder.

This is something we should discuss for other modules as well. For now, there’s no overlap between functions and function tags since all our functions are considered private. However, for other resources like block tags and predicates, I think the header alone isn’t enough to indicate what counts as a feature.

I’m generally not a fan of visibility by naming, but it’s starting to feel necessary, and internal seems like the best term for it.

Related Issues

Additional Notes

Tasks to complete before merging

  • I agree to release my contribution under the MPL v2 License.
  • My pull request is associated with an existing issue.
  • I have updated the changelog to reflect my contribution.
  • If this pull request adds or modifies a feature:
    • I have documented my changes in the /docs folder.
    • I have updated the metadata of the feature. See feature metadata.
    • I have thoroughly tested my changes. See testing guidelines.

@aksiome aksiome marked this pull request as ready for review November 2, 2025 16:50
@aksiome aksiome requested a review from theogiraudet November 2, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add redstone related features to the block module

1 participant