✨ feat(bs.block): add redstone related features #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the
is_conductiveandis_spawnablefunctions by predicates.It also adds 3 new predicates related to redstone:
is_poweredis_strongly_poweredis_weakly_poweredand 3 new functions:
is_touching_poweris_touching_strong_poweris_touching_weak_powerIt also reorganizes things slightly by moving internal .json files into an internal folder.
This is something we should discuss for other modules as well. For now, there’s no overlap between functions and function tags since all our functions are considered private. However, for other resources like block tags and predicates, I think the header alone isn’t enough to indicate what counts as a feature.
I’m generally not a fan of visibility by naming, but it’s starting to feel necessary, and internal seems like the best term for it.
Related Issues
Additional Notes
Tasks to complete before merging
/docsfolder.