Add comprehensive C++ style guide review and freestanding C++ guidelines

[Copilot]

This PR provides a comprehensive review of the MaxOS codebase focusing on C++ style guide compliance and freestanding standard library usage, as requested in the issue.

What's Added

📋 Code Review Document (docs/CODE_REVIEW_CPP_STYLE.md)

A detailed analysis of the entire codebase against the project's coding style guide, identifying:

• Comment style issues: 18+ instances of TODO/FIXME comments missing proper formatting (missing space after //, inline instead of above code)
• Virtual method declarations: ~10 cases where override is used without the virtual keyword (violates style guide requirement)
• Naming inconsistencies: Some enums using old-style instead of enum class, occasional getter naming issues
• Prioritized recommendations: Organized into High/Medium/Low priority with specific file locations and line numbers

📚 Freestanding C++ Guidelines (docs/Styles/Freestanding C++ Guidelines.md)

An educational guide specifically for MaxOS's freestanding environment, covering:

• What is freestanding C++: Clear explanation of the constraints and implications
• Allowed vs. forbidden headers: Comprehensive lists with examples
  • ✅ Allowed: <cstdint>, <cstddef>, <type_traits>, <limits> (C++20 freestanding)
  • ❌ Forbidden: <string>, <vector>, <algorithm>, <iostream>, etc.
• Best practices: How to write effective freestanding code
• Common patterns: Iteration, sorting, move semantics without STL
• Memory management: Custom new/delete operators, alignment
• Migration guide: For porting hosted code to freestanding

📖 Review Summary (docs/CODE_REVIEW_README.md)

A quick-reference navigation document for contributors with key findings and getting started guidance.

Key Findings

✅ Excellent Freestanding Compliance

The codebase demonstrates strong understanding of freestanding C++ requirements:

• No hosted standard library usage detected
• Only appropriate freestanding headers used (<stdint.h>, <stddef.h>, <stdarg.h>)
• Well-designed custom implementations (String, Vector, Map) with small-string optimization
• Build system correctly configured (-ffreestanding -fno-exceptions -fno-rtti -nostdlib)
• Proper use of modern C++ features (C++20, constexpr, [[nodiscard]], concepts-ready)

📝 Style Issues Are Minor

Most issues are formatting inconsistencies that don't affect functionality:

• Comment spacing and placement
• Missing virtual keywords on override methods
• Enum modernization opportunities

Overall Assessment: The codebase is well-structured and adheres to freestanding principles. The identified issues can be addressed incrementally.

Benefits

These documents provide:

• Actionable feedback with specific locations for improvements
• Educational resources for team members unfamiliar with freestanding C++
• Onboarding material for new contributors
• Style guide compliance tracking for code reviews
• Best practices tailored to kernel/OS development

Testing

No code changes were made—only documentation added. All new files follow markdown formatting and have been verified for accuracy against the actual codebase.

---

Closes #[issue_number] (if applicable)

Original prompt

Review all files in this repository and highlight potential issues or improvements. Mainly asking for c++ style guides within a freestanding std

Created from VS Code via the GitHub Pull Request extension.

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.