Skip to content

Conversation

@AltamashShaikh
Copy link
Contributor

@AltamashShaikh AltamashShaikh commented Oct 23, 2025

Description:

Allow adding an additional component to password confirmation modal and make the Modal title of password confirmation more generic.

This allows plugin like LoginSAML to extend the password confirmation modal and add a button like reAuth to skip password confirmation.

Update the password confirmation modal title to more generic, to support cases where password is not required but still requires authentication.

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Oct 23, 2025
@AltamashShaikh AltamashShaikh requested a review from a team October 23, 2025 13:38
@michalkleiner
Copy link
Contributor

@AltamashShaikh can you please merge in latest 5.x-dev and re-update the UI test screenshot after the latest changes there? Thanks! Also a temporary TagManager submodule to a PR branch that updates the UI screenshot there would also be good to make sure we have a green CI. Once this is merged, we can merge the TagManager PR and update submodules afterwards.

@AltamashShaikh
Copy link
Contributor Author

@michalkleiner Created matomo-org/tag-manager#1051 to updated TagManager.

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge once the LoginSAML part is ready, so we can ensure we don't need any further changes to this.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review PRs that need a code review Stale The label used by the Close Stale Issues action

Development

Successfully merging this pull request may close these issues.

4 participants