- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.8k
 
Allow adding an additional component to password confirmation modal #23703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.x-dev
Are you sure you want to change the base?
Conversation
| 
           @AltamashShaikh can you please merge in latest   | 
    
| 
           @michalkleiner Created matomo-org/tag-manager#1051 to updated TagManager.  | 
    
        
          
                plugins/CorePluginsAdmin/vue/src/PasswordConfirmation/PasswordConfirmation.vue
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                plugins/CorePluginsAdmin/vue/src/PasswordConfirmation/PasswordConfirmation.vue
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                plugins/CorePluginsAdmin/vue/src/PasswordConfirmation/PasswordConfirmation.vue
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's merge once the LoginSAML part is ready, so we can ensure we don't need any further changes to this.
| 
           This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers  | 
    
Description:
Allow adding an additional component to password confirmation modal and make the Modal title of password confirmation more generic.
This allows plugin like LoginSAML to extend the password confirmation modal and add a button like reAuth to skip password confirmation.
Update the password confirmation modal title to more generic, to support cases where password is not required but still requires authentication.
Review