Skip to content

Conversation

@fealXX
Copy link

@fealXX fealXX commented Sep 19, 2025

Description:

Use the idGoal from Sparkline URL to update the datatable, instead of always using page default / first idGoal, so that the Ecommerce Overview is able to load the abandoned cart metrics, instead of always falling back to idGoal=ecommerceOrder

adresses #22713 (edit: also #21957 / #22014 )

Review

@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Oct 14, 2025
@fealXX
Copy link
Author

fealXX commented Oct 29, 2025

Anything I can do to help facilitate merging this? :)

Use the idGoal from Sparkline URL to update the datatable, instead of always using page default, so that the Ecommerce Overview is able to load the abandoned cart metrics
@sgiehl
Copy link
Member

sgiehl commented Oct 29, 2025

Hey @fealXX. I've just had a look at the fix. It works in terms of loading the overview chart with the correct metric.
However when switching to "Abandoned Carts" metric, the metric selector within the evolution chart then only allows selecting such metrics and in addition also some metrics that shouldn't be displayed at all.
The optimal way for sure would be to allow the chart to show all metrics together. But that might be a bit tricky due to the differing goal id.

@fealXX
Copy link
Author

fealXX commented Oct 29, 2025

@sgiehl while I do agree on the optimal way, it seems (to me) a rework of this logic is out of scope for the issue that is being adressed. I will have a look at the metric selector and why it behaves that way, thank you for spotting this. :)

@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants