Use builder images in dockerfiles #860
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emonty
force-pushed
the
master
branch
2 times, most recently
from
c7fb287 to
2fb9c6f
Compare
The final tippecanoe image doesn't need the compiler in it. By using a builder image, we can install the compiler and build tippecanoe, then copy the results into a smaller final image. In Travis, run a build that stops on the builder image stage so that make test can be run in the script stage. In normal usage for a user that's not necessary. Update the travis image to bionic, as trusty is now in extended maint - and the only thing these jobs are doing is running docker. While we're in there, update centos to centos8 and ubuntu to 20.04, but add build args that allow overriding that if desired. Finally, ubuntu doesn't need build-essential, which pulls in all of the tools needed to build debian packages. Like centos it just needs gcc, g++ and make.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final tippecanoe image doesn't need the compiler in it. By
using a builder image, we can install the compiler and build
tippecanoe, then copy the results into a smaller final image.
In Travis, run a build that stops on the builder image stage
so that make test can be run in the script stage. In normal
usage for a user that's not necessary. Update the travis image
to bionic, as trusty is now in extended maint - and the only
thing these jobs are doing is running docker.
While we're in there, update centos to centos8 and ubuntu to 20.04,
but add build args that allow overriding that if desired.
Finally, ubuntu doesn't need build-essential, which pulls in all
of the tools needed to build debian packages. Like centos it just
needs gcc, g++ and make.